Re: [PATCH 4/6] DSPBRIDGE: Remove unused variables from resource cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2010-01-19 at 21:54 +0100, ext Omar Ramirez Luna wrote:
> From: Fernando Guzman Lugo <x0095840@xxxxxx>
> 
> This patch removes an unused variable parameter from
> resource cleanup code.
> 
> Signed-off-by: Fernando Guzman Lugo <x0095840@xxxxxx>
> ---
>  .../plat-omap/include/dspbridge/resourcecleanup.h  |    3 +--
>  drivers/dsp/bridge/rmgr/drv.c                      |    5 +----
>  drivers/dsp/bridge/rmgr/strm.c                     |    4 ++--
>  3 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/include/dspbridge/resourcecleanup.h b/arch/arm/plat-omap/include/dspbridge/resourcecleanup.h
> index a6f4397..4ded5aa 100644
> --- a/arch/arm/plat-omap/include/dspbridge/resourcecleanup.h
> +++ b/arch/arm/plat-omap/include/dspbridge/resourcecleanup.h
> @@ -63,8 +63,7 @@ extern DSP_STATUS DRV_GetDMMResElement(u32 pMapAddr, HANDLE dmmRes,
>  
>  extern DSP_STATUS DRV_RemoveDMMResElement(HANDLE dmmRes, HANDLE pCtxt);
>  
> -extern DSP_STATUS DRV_ProcUpdateSTRMRes(u32 uNumBufs, HANDLE STRMRes,
> -					HANDLE pCtxt);
> +extern DSP_STATUS DRV_ProcUpdateSTRMRes(u32 uNumBufs, HANDLE STRMRes);
>  
>  extern DSP_STATUS DRV_ProcInsertSTRMResElement(HANDLE hStrm, HANDLE STRMRes,
>  						HANDLE pPctxt);
> diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c
> index 7e85095..56ceb6c 100644
> --- a/drivers/dsp/bridge/rmgr/drv.c
> +++ b/drivers/dsp/bridge/rmgr/drv.c
> @@ -339,7 +339,6 @@ DSP_STATUS DRV_GetDMMResElement(u32 pMapAddr, HANDLE hDMMRes, HANDLE hPCtxt)
>  	struct PROCESS_CONTEXT *pCtxt = (struct PROCESS_CONTEXT *)hPCtxt;
>  	struct DMM_RES_OBJECT **pDMMRes = (struct DMM_RES_OBJECT **)hDMMRes;
>  	DSP_STATUS status = DSP_SOK;
> -	struct DMM_RES_OBJECT *pTempDMM2 = NULL;
>  	struct DMM_RES_OBJECT *pTempDMM = NULL;
>  
>  	DBC_Assert(hPCtxt != NULL);
> @@ -349,7 +348,6 @@ DSP_STATUS DRV_GetDMMResElement(u32 pMapAddr, HANDLE hDMMRes, HANDLE hPCtxt)
>  			 "DRV_GetDMMResElement: 2 pTempDMM:%x "
>  			 "pTempDMM->ulDSPAddr:%x pMapAddr:%x\n", pTempDMM,
>  			 pTempDMM->ulDSPAddr, pMapAddr);
> -		pTempDMM2 = pTempDMM;
>  		pTempDMM = pTempDMM->next;
>  	}
>  	if (pTempDMM != NULL) {
> @@ -579,12 +577,11 @@ DSP_STATUS DRV_GetSTRMResElement(HANDLE hStrm, HANDLE hSTRMRes, HANDLE hPCtxt)
>  }
>  
>  /* Updating the stream resource element */
> -DSP_STATUS DRV_ProcUpdateSTRMRes(u32 uNumBufs, HANDLE hSTRMRes, HANDLE hPCtxt)
> +DSP_STATUS DRV_ProcUpdateSTRMRes(u32 uNumBufs, HANDLE hSTRMRes)
>  {
>  	DSP_STATUS status = DSP_SOK;
>  	struct STRM_RES_OBJECT **STRMRes = (struct STRM_RES_OBJECT **)hSTRMRes;
>  
> -	DBC_Assert(hPCtxt != NULL);
>  	(*STRMRes)->uNumBufs = uNumBufs;
>  	return status;
>  }
> diff --git a/drivers/dsp/bridge/rmgr/strm.c b/drivers/dsp/bridge/rmgr/strm.c
> index b0b4d32..febb6c2 100644
> --- a/drivers/dsp/bridge/rmgr/strm.c
> +++ b/drivers/dsp/bridge/rmgr/strm.c
> @@ -158,7 +158,7 @@ DSP_STATUS STRM_AllocateBuffer(struct STRM_OBJECT *hStrm, u32 uSize,
>  
>  	if (DRV_GetSTRMResElement(hStrm, &hSTRMRes, pr_ctxt) !=
>  			DSP_ENOTFOUND)
> -		DRV_ProcUpdateSTRMRes(uNumBufs, hSTRMRes, pr_ctxt);
> +		DRV_ProcUpdateSTRMRes(uNumBufs, hSTRMRes);
>  #endif
>  func_end:
>  	return status;
> @@ -340,7 +340,7 @@ DSP_STATUS STRM_FreeBuffer(struct STRM_OBJECT *hStrm, u8 **apBuffer,
>  #ifndef RES_CLEANUP_DISABLE
>  	if (DRV_GetSTRMResElement(hStrm, hSTRMRes, pr_ctxt) !=
>  			DSP_ENOTFOUND)
> -		DRV_ProcUpdateSTRMRes(uNumBufs-i, hSTRMRes, pr_ctxt);
> +		DRV_ProcUpdateSTRMRes(uNumBufs-i, hSTRMRes);
>  #endif
>  	return status;
>  }

Acked-by: Ameya Palande <ameya.palande@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux