Hi Romit, >From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > >Menon, Nishanth wrote: >> Dasgupta, Romit had written, on 01/19/2010 08:43 AM, the following: >>>>> 3430 opps, and we should move it to opp34xx.c(I hate having new >files :( ).. >>>>> It should be only >>>>> #ifdef CONFIG_CPU_FREQ. OPP has nothing to do with CONFIG_PM. >>>>> >>>>> Why do you need CPU_FREQ for suspend/resume?? >>>>> >>>> voltage control - SR needs to query for voltage? >>>> >>> Why should suspend/resume be dependent on SR? >> please see the code logic -> when SR is enabled and OFF/RET happens, you >> need the voltage for the current frequency so that you can disable SR, >> set the nominal voltage for the current OPP then go to WFI. >> >You do not need the OPP table for querying voltage alone. You can read that >from the OMAP chip registers directly. So OPP layer is not necessary when >we do not use cpufreq! I do agree that we should not need CPUfreq, but cannot use the voltage from the VP either; you need to set the nominal voltage to be safe not the one after SR correction. Eventually it will have to be handled by the SR layer. Regards, Benoit Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
