On Tue, Jan 19, 2010 at 01:01:32PM +0100, ext Nishanth Menon wrote:
> Eduardo Valentin said the following on 01/19/2010 05:57 AM:
> > From: Eduardo Valentin <eduardo.valentin@xxxxxxxxx>
> >
> > This patch removes the compilation error when compiling
> > kernel with CONFIG_PM=N. The problem was that omap3_pm_init_opp_table
> > was not defined if CONFIG_PM=N.
> >
> > Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxx>
> > ---
> > arch/arm/mach-omap2/pm.h | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> > index d257225..5fc056f 100644
> > --- a/arch/arm/mach-omap2/pm.h
> > +++ b/arch/arm/mach-omap2/pm.h
> > @@ -69,7 +69,13 @@ static inline void omap3_pm_init_vc(struct prm_setup_vc *setup_vc)
> > * Initialize the basic opp table here, board files could choose to modify opp
> > * table after the basic initialization
> > */
> > +#ifdef CONFIG_PM
> > extern void omap3_pm_init_opp_table(void);
> > +#else
> > +static inline void omap3_pm_init_opp_table(void)
> > +{
> > +}
> > +#endif
> >
> > extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
> > extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
> >
> Err... NAK.. I think you missed
> http://marc.info/?t=126356119700001&r=1&w=2 ?
> there seems to be an issue else where, I have not dug at it yet..
Yeah. OK, I couldn't see the logs as the dumps has been removed already from that thread.
But if I got the problem correctly, the problem is when CONFIG_PM is not set but cpu freq is.
And if there is any call to new omap opp layer helper functions, then it will BUG the system.
Causing hangs.
I guess one way to solve this is to bind compilation of omap opp layer to CONFIG_PM and CONFIG_CPU_FREQ.
If either is disabled, then omap opp layer must be nops.
What do you think?
I am sending a patch to do the above.
> Regards,
> Nishanth Menon
--
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
