> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Sunday, January 17, 2010 12:56 AM > To: Shilimkar, Santosh > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/4] omap: Clean the serial port defines > > * Shilimkar, Santosh <santosh.shilimkar@xxxxxx> [100115 23:46]: > > Thanks for the nice cleanup. > > Thanks for testing :) > > > <snip> > > > --- a/arch/arm/plat-omap/include/plat/common.h > > > +++ b/arch/arm/plat-omap/include/plat/common.h > > > @@ -47,6 +47,10 @@ struct omap_globals { > > > void __iomem *prm; /* Power and Reset Management */ > > > void __iomem *cm; /* Clock Management */ > > > void __iomem *cm2; > > > + unsigned long uart1_phys; > > > + unsigned long uart2_phys; > > > + unsigned long uart3_phys; > > > + unsigned long uart4_phys; > > Considering they are register base address, can > > these be declared as "void __iomem" instead of "unsigned long" > > These are physical addresses instead of virtual addresses. > They get ioremapped in mach-omap[12]/serial.c. So they should > not be void __iomem * in omap_globals. Yep. I see your point. > BTW, we should eventually change everything in omap_globals > to be physical addresses. We did some work for OMAP4 to move most of the things to ioremap istead of those hardcoded macros. Let me know when you want to do this clean up. We can do this together. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
