* Shilimkar, Santosh <santosh.shilimkar@xxxxxx> [100115 23:46]:
> Thanks for the nice cleanup.
Thanks for testing :)
> <snip>
> > --- a/arch/arm/plat-omap/include/plat/common.h
> > +++ b/arch/arm/plat-omap/include/plat/common.h
> > @@ -47,6 +47,10 @@ struct omap_globals {
> > void __iomem *prm; /* Power and Reset Management */
> > void __iomem *cm; /* Clock Management */
> > void __iomem *cm2;
> > + unsigned long uart1_phys;
> > + unsigned long uart2_phys;
> > + unsigned long uart3_phys;
> > + unsigned long uart4_phys;
> Considering they are register base address, can
> these be declared as "void __iomem" instead of "unsigned long"
These are physical addresses instead of virtual addresses.
They get ioremapped in mach-omap[12]/serial.c. So they should
not be void __iomem * in omap_globals.
BTW, we should eventually change everything in omap_globals
to be physical addresses.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
