Romit Dasgupta <romit@xxxxxx> writes: >> - omap2_init_common_hw(NULL, NULL, NULL, NULL, NULL); >> + omap2_init_common_hw(NULL, NULL); > > > A call to a function with NULL parameters suggests that the function is doing > more than it should. Not necessarily. It can also suggest that this board does not want to override any default settings. > I think omap2_init_common_hw and omap2_sdrc_init, > _omap2_init_reprogram_sdrc, gpmc init can be separated from > omap2_init_common_hw. > > If you are refactoring the code may be this should be taken care as > well. In this case, Nishanth is not refactoring, he's just removing some code added earlier in the PM branch that is no longer needed. A patch to do what you suggest (which is a good idea) should be a separate patch and generated against l-o master. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
