> - omap2_init_common_hw(NULL, NULL, NULL, NULL, NULL); > + omap2_init_common_hw(NULL, NULL); A call to a function with NULL parameters suggests that the function is doing more than it should. I think omap2_init_common_hw and omap2_sdrc_init, _omap2_init_reprogram_sdrc, gpmc init can be separated from omap2_init_common_hw. If you are refactoring the code may be this should be taken care as well. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html