Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
From: Paul Walmsley <paul@xxxxxxxxx>
Date: Thu, 3 Dec 2009 08:26:55 -0700 (MST)
Cc: linux-omap@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Nishanth Menon <nm@xxxxxx>, Felipe Balbi <felipe.balbi@xxxxxxxxx>
In-reply-to: <20091203150300.GB26651@xxxxxxxxxxxxxxxxxxxxxx>
References: <20091203095830.1203.76290.stgit@xxxxxxxxxxxxxxxxxxxxx> <20091203100707.1203.98247.stgit@xxxxxxxxxxxxxxxxxxxxx> <20091203102700.GA30423@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.0912030331360.13408@xxxxxxxxxxxxxxxxxx> <20091203104354.GB20379@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.0912030355050.13408@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.0912030424050.13408@xxxxxxxxxxxxxxxxxx> <20091203121157.GC20379@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.0912030520360.13408@xxxxxxxxxxxxxxxxxx> <20091203150300.GB26651@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)

Hello Russell,

On Thu, 3 Dec 2009, Russell King - ARM Linux wrote:

> On Thu, Dec 03, 2009 at 05:33:44AM -0700, Paul Walmsley wrote:
> > My preference was to keep data separated from code in the source files; I 
> > think it is slightly more readable.
> 
> It's less readable because instead of having similar stuff together, it's
> at opposite ends of the file.

Okay.  Our opinions differ.  I'm happy to make this change to align it 
with what you like.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- [PATCH v3 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Paul Walmsley

References:
- [PATCH 0/8] OMAP clock: convert static definitions in header files to C files
  - From: Paul Walmsley
- [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Paul Walmsley
- Re: [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Russell King
- Re: [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Paul Walmsley
- Re: [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Russell King - ARM Linux
- Re: [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Paul Walmsley
- [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Paul Walmsley
- Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Russell King - ARM Linux
- Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Paul Walmsley
- Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
  - From: Russell King - ARM Linux

Prev by Date: Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
Next by Date: Re: [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@xxxxxxxxx>
Previous by thread: Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
Next by thread: [PATCH v3 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
Index(es):
- Date
- Thread

[Index of Archives] [Linux Arm (vger)] [ARM Kernel] [ARM MSM] [Linux Tegra] [Linux WPAN Networking] [Linux Wireless Networking] [Maemo Users] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux SCSI]