Hello Russell, On Tue, 1 Dec 2009, Russell King - ARM Linux wrote: > On Tue, Dec 01, 2009 at 05:51:39AM -0700, Paul Walmsley wrote: > > On Tue, 1 Dec 2009, Russell King - ARM Linux wrote: > > > > > On Tue, Dec 01, 2009 at 05:57:24PM +0530, Rajendra Nayak wrote: > > > > This patch defines all the clock nodes in OMAP4430 > > > > platform. Autogenerated using a python script (gen_clock_tree.py) > > > > developed by Paul Walmsley, Benoit Cousson and Rajendra Nayak. > > > > > > Can we please get away from this idea of putting major structure > > > definitions in header files? > > > > Any objections to calling the clock data file something like > > "clock44xx_data.c", and including it into clock44xx.c the same way we > > currently do with the .h file? > > How about having clock44xx_data.c as you suggest, moving the clkdev > definitions into there, along with the registration of the clocks, > and have it as an entirely separate .c file with no #include games? This has been done now for OMAP1, 2, and 3. Patches on the way, - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html