Hello Vishwanath, On Tue, 1 Dec 2009, Sripathy, Vishwanath wrote: > > -----Original Message----- > > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > > Sent: Monday, November 30, 2009 1:57 PM > > To: Sripathy, Vishwanath > > Cc: linux-omap@xxxxxxxxxxxxxxx > > Subject: Re: [PATCHV3 2/4] OMAP3: Clock Type change for OMAP3 Clocks > > > > Hi Vishwanath, > > > > On Thu, 26 Nov 2009, Vishwanath BS wrote: > > > > > In omap34xx_clks, CK_343X type is used by all OMAP3 family of > > > processors. It makes more sense to name clock type as CK_3XXX since it > > > is common to all OMAP3 processors. > > > > Hmmm. Do all of the CK_3XXX clocks apply to AM3503/3517? > > > Currently all OMAP3 chip families are using CK_343X as the common clock > and this clock has been renamed to CK_3XXX. So CK_3XXX should be > applicable for all. Just based on a quick spot-check, there are several clocks that this patch marks as CK_3XXX that are really only applicable to the 34xx and 36xx families. For example: > > > - CLK(NULL, "sdrc_ick", &sdrc_ick, CK_343X), > > > + CLK(NULL, "sdrc_ick", &sdrc_ick, CK_3XXX), > > > - CLK(NULL, "iva2_ck", &iva2_ck, CK_343X), > > > + CLK(NULL, "iva2_ck", &iva2_ck, CK_3XXX), We should not mark clocks that are not present on 3503/3517 as being present on 3XXX, otherwise this chip numbering scheme will become even more perplexing than it currently is. How about adding RATE_IN_36XX or CK_36XX as appropriate? - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
