On Fri, Nov 27, 2009 at 05:47:40PM +0200, Grazvydas Ignotas wrote: > On Fri, Nov 27, 2009 at 4:54 PM, Anton Vorontsov > >> + ? ? /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which > >> + ? ? ?* we don't want and can't tolerate. ?Although it might be > >> + ? ? ?* friendlier not to borrow this thread context... > >> + ? ? ?*/ > >> + ? ? local_irq_enable(); > >> +#endif > > Can you explain why the driver can't tolerate disabled irqs? > > Calling schedule_delayed_work() from an irq context should be OK. > Ah, this is leftover from TI code this driver is based on, which used > to do more things directly in interrupt handler. So I guess it can be > removed, updated patch attached. Actually, the genirq infrastructure in 2.6.32 has been improved to allow I2C based interrupt controllers properly so even those twl4030 drivers that do I/O in interrupt callbacks should now be able to run without these workarounds once the core has been updated. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
