> -----Original Message----- > From: Sergey Lapin [mailto:slapinid@xxxxxxxxx] > Sent: Friday, November 27, 2009 6:08 PM > To: Premi, Sanjeev > Cc: Kevin Hilman; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: OMAP3: enabling CPU idle leads to panic > > >> -----Original Message----- > >> From: Sergey Lapin [mailto:slapinid@xxxxxxxxx] > >> Sent: Friday, November 27, 2009 5:33 PM > >> To: Premi, Sanjeev > >> Cc: Kevin Hilman; linux-omap@xxxxxxxxxxxxxxx > >> Subject: Re: OMAP3: enabling CPU idle leads to panic > >> > >> On Fri, Nov 27, 2009 at 2:36 PM, Sergey Lapin > >> <slapinid@xxxxxxxxx> wrote: > >> >> > >> >> Alas, that's not because omap_chip_is() function fails > >> >> on these structures. > >> >> > >> > > >> > I mean during registration of power domains. > >> > > >> [snip]--[snip] > > Had submitted a patch earlier; will need some time to > > find it. > > > > } else if (cpu_is_omap343x()) { > > omap_chip.oc = CHIP_IS_OMAP3430; > > if (omap_rev() == OMAP3430_REV_ES1_0) > > omap_chip.oc |= CHIP_IS_OMAP3430ES1; > > else if (omap_rev() >= OMAP3430_REV_ES2_0 && > > omap_rev() <= OMAP3430_REV_ES2_1) > > omap_chip.oc |= CHIP_IS_OMAP3430ES2; > > else if (omap_rev() == OMAP3430_REV_ES3_0) > > omap_chip.oc |= CHIP_IS_OMAP3430ES3_0; > > else if (omap_rev() == OMAP3430_REV_ES3_1) > > omap_chip.oc |= CHIP_IS_OMAP3430ES3_1; > > } else { > > > > In meantime, can you try setting the following (explicitly) > > to the code above: > > else if (omap_rev() == OMAP3430_REV_ES3_1) > > omap_chip.oc |= CHIP_IS_OMAP3430ES3_1; > > + else > > + omap_chip.oc |= CHIP_IS_OMAP3430ES3_1 > > > > ~sanjeev > > It is fixed, no more panics, thanks a lot! > Great! I will take ongoing touchscreen issues to closure and submit a formal patch again. ~sanjeev-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
