Wednesday 25 November 2009 14:54:47 Janusz Krzysztofik napisał(a):
> Wednesday 25 November 2009 10:02:52 Paul Walmsley napisał(a):
> > On Sat, 21 Nov 2009, Janusz Krzysztofik wrote:
> > >
> > > diff -uprN git.orig/arch/arm/mach-omap1/Makefile git/arch/arm/mach-omap1/Makefile
> > > --- git.orig/arch/arm/mach-omap1/Makefile 2009-11-21 00:38:45.000000000 +0100
> > > +++ git/arch/arm/mach-omap1/Makefile 2009-11-21 01:27:12.000000000 +0100
> > > @@ -3,7 +3,7 @@
> > > #
> > >
> > > # Common support
> > > -obj-y := io.o id.o sram.o clock.o irq.o mux.o serial.o devices.o
> > > +obj-y := io.o id.o sram.o clock.o irq.o lcd_dma.o mux.o serial.o devices.o
> >
> > It seems that this LCD DMA controller is not present on OMAPs prior to
> > the 1510, given all the references in the LCD DMA code to 1510 and 1610,
> > etc. It might be good to add a Kconfig option so OMAP730/850 users can
> > skip compiling it and save some memory. The drivers that use these
> > routines can then include Kconfig dependencies on that option so it is
> > automatically included when those drivers are built.
>
> OK, will prepare that for next iteration.
Paul,
It turned out not that simple. Since arch/arm/mach-omap1/lcd_dma.c exports
several functions that are called unconditionaly from
drivers/video/omap/lcdc.c AND the latter is linked into the omapfb driver
based on CONFIG_ARCH_OMAP1=y, linking in the former can't be limited to
selected OMAP1 subarchs unless at least drivers/video/omap/{Kconfig,Makefile},
if not drivers/video/omap/lcdc.c itself either, are modified for that as well.
Am I missing something?
If not, I can see two options:
1. Keep arch/arm/mach-omap1/lcd_dma.c linked in for any OMAP1 subarch unless
CONFIG_FB_OMAP is not set. That can be cleaned up further after the
drivers/video/omap/* stuff is ever modified.
2. Include drivers/video/omap/* modifications into this series.
What do you suggest?
Thanks,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
