Hi, > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of ext > Sonasath, Moiz > Sent: 23. marraskuuta 2009 18:10 > To: Kalle Jokiniemi > Cc: khilman@xxxxxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; > Jarkko Nikula; Paul Walmsley; Menon, Nishanth; Pandita, > Vikram; Hogander Jouni (Nokia-D/Tampere) > Subject: RE: [PATCH V4 3/3] OMAP: I2C: Add mpu wake up > latency constraint in i2c > <<snip-snip>> > > > > Well, I don't completely agree with the necessity of preparing for > > different rx/tx thresholds. For this to make sense, the i2c-omap > > driver should first separate in it's code the use of rx and tx > > thresholds. If someone is planning to do that, he/she should anyway > > update the usage of fifo_size throughout the code, > including the wake up latency setting. > > > > Anyways, attached a patch that separates the mpu wake up > latencies for > > rx and tx. In case that is needed. Though I'm not for it, since it > > adds unneeded complexity. > > > > Yes Kalle, you are right! Not having different RX/TX wake-up > latencies will absolutely work fine with the in-place code as > we have both the RX/TX thresholds same. Great :) > But, I think in > future we might have to play around with different RX/TX > thresholds and so from a conceptually right and generic point > of view it makes sense to incur the cost of the added complexity. I agree. Once someone differentiates the thresholds in the driver, it very much makes sense to also calculate different mpu wake up latencies for RX and TX. > > The patch V4 looks perfect to me :) Great :) So, where do we push it? - Kalle > > - Moiz > > > - Kalle > > > > > > > > > > > > > /* reset ASAP, clearing any IRQs */ diff --git > > > > a/include/linux/i2c-omap.h b/include/linux/i2c-omap.h new file > > > > mode 100644 index 0000000..1362fba > > > > --- /dev/null > > > > +++ b/include/linux/i2c-omap.h > > > > @@ -0,0 +1,9 @@ > > > > +#ifndef __I2C_OMAP_H__ > > > > +#define __I2C_OMAP_H__ > > > > + > > > > +struct omap_i2c_bus_platform_data { > > > > + u32 clkrate; > > > > + void (*set_mpu_wkup_lat)(struct > device *dev, int set); > > > > +}; > > > > + > > > > +#endif > > > > -- > > > > 1.5.4.3 > > > > > > Regards > > > Moiz Sonasath > > > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-omap" in the body of a message to > majordomo@xxxxxxxxxxxxxxx More majordomo info at > http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
