* Aguilar Pena, Leed <leed.aguilar@xxxxxx> [091119 10:34]: > For TWL family of power management ICs, USB charging works only > when USB regulators are in enabled state: 3v1, 1v5, 1v8 > > On a USB cable attach, twl4030_phy_resume(twl) function enables > the regulators. Enable USB charging, only after all regulators > are enabled. > > Its observed that enabling USB charging before regulators are > enabled, causes USB charging to fail. > > Tested on: Zoom2: omap3430: ES3.1 + TWL5030 > Needs T2-MADC and T2-BCI drivers which are still not upstreamed. This should go to linux-usb list with linux-omap list Cc'd. Regards, Tony > Signed-off-by: Moiz Sonasath <m-sonasath@xxxxxx> > Signed-off-by: Leed Aguilar <leed.aguilar@xxxxxx> > Acked-by: Vikram Pandita <vikram.pandita@xxxxxx> > Acked-by: Anand Gadiyar <gadiyar@xxxxxx> > Acked-by: Nishanth Menon <nm@xxxxxx> > > --- > drivers/usb/otg/twl4030-usb.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c > index 9e3e7a5..bd9883f 100644 > --- a/drivers/usb/otg/twl4030-usb.c > +++ b/drivers/usb/otg/twl4030-usb.c > @@ -598,12 +598,12 @@ static irqreturn_t twl4030_usb_irq(int irq, void *_twl) > * USB_LINK_VBUS state. musb_hdrc won't care until it > * starts to handle softconnect right. > */ > - twl4030charger_usb_en(status == USB_LINK_VBUS); > - > if (status == USB_LINK_NONE) > twl4030_phy_suspend(twl, 0); > else > twl4030_phy_resume(twl); > + > + twl4030charger_usb_en(status == USB_LINK_VBUS); > } > sysfs_notify(&twl->dev->kobj, NULL, "vbus"); > > -- > 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
