On Mon, Nov 23, 2009 at 5:25 AM, Ladislav Michl
<Ladislav.Michl@xxxxxxxxx> wrote:
[...]
>> @@ -167,6 +168,8 @@ struct mmc_omap_host {
>> spinlock_t clk_lock; /* for changing enabled state */
>> unsigned int fclk_enabled:1;
>>
>> + unsigned reg_shift:1;
>> +
> [...]
> Here you made reg_shift one bit wide variable...
>
>> @@ -1490,6 +1493,8 @@ static int __init mmc_omap_probe(struct platform_device *pdev)
>> }
>> }
>>
>> + host->reg_shift = (cpu_is_omap7xx() ? 1 : 2);
>> +
> ...and here you are possibly trying to set second bit of that variable. It does
> not work.
Ah, clumsy mistake, I'll fix it and resubmit.
> And sorry to ask again. This very driver works reliable and there are no
> timeouts like this
> mmci-omap mmci-omap.0: command timeout (CMD8)
> mmci-omap mmci-omap.0: command timeout (CMD5)
> mmci-omap mmci-omap.0: command timeout (CMD5)
> mmci-omap mmci-omap.0: command timeout (CMD5)
> mmci-omap mmci-omap.0: command timeout (CMD5)
> mmci-omap mmci-omap.0: command timeout (CMD55)
> mmci-omap mmci-omap.0: command timeout (CMD55)
> mmci-omap mmci-omap.0: command timeout (CMD55)
> mmci-omap mmci-omap.0: command timeout (CMD55)
> while detecting MMC card on OMAP730? (because I can see them on 5910). This question
> is unrelated to your patch.
When booting up, I see the first set of timeouts (CMD8 and CMD5), but
I don't get any timeouts on 55, and it starts up correctly for me,
detecting my SD card and mounting it. I've got an Angstrom
installation on my SD card and can boot all the way into it with this
patch.
Not sure if it matters, but this is against the linux-omap for-next branch.
- Cory
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
