> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Gregoire Gentil > Sent: Thursday, November 19, 2009 10:48 PM > To: linux-omap@xxxxxxxxxxxxxxx > Cc: Gregoire Gentil; Tony Lindgren; Tim Yamin > Subject: [PATCH 7/8] Video driver of Always Innovating OMAP3-based > Touch Book > > > Signed-off-by: Gregoire Gentil <gregoire@xxxxxxxxxx> > --- > drivers/video/omap/lcd_omap3touchbook.c | 130 > +++++++++++++++++++++++++++++++ > 1 files changed, 130 insertions(+), 0 deletions(-) > create mode 100644 drivers/video/omap/lcd_omap3touchbook.c > > diff --git a/drivers/video/omap/lcd_omap3touchbook.c > b/drivers/video/omap/lcd_omap3touchbook.c > new file mode 100644 > index 0000000..5b58703 > --- /dev/null > +++ b/drivers/video/omap/lcd_omap3touchbook.c > @@ -0,0 +1,130 @@ > +/* > + * LCD panel support for the Touch Book > + * > + * Author: Gregoire Gentil <gregoire@xxxxxxxxxx> > + * > + * Derived from drivers/video/omap/lcd-omap3beagle.c > + * > + * This program is free software; you can redistribute it and/or > modify it > + * under the terms of the GNU General Public License as published > by the > + * Free Software Foundation; either version 2 of the License, or > (at your > + * option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public > License along > + * with this program; if not, write to the Free Software > Foundation, Inc., > + * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. > + */ > + > +#include <linux/module.h> > +#include <linux/platform_device.h> > +#include <linux/gpio.h> > +#include <linux/i2c/twl4030.h> > + > +#include <plat/mux.h> > +#include <plat/omapfb.h> > +#include <asm/mach-types.h> > + > +#define LCD_PANEL_ENABLE_GPIO 176 > + > +static int omap3beagle_panel_init(struct lcd_panel *panel, > + struct omapfb_device *fbdev) > +{ > + gpio_request(LCD_PANEL_ENABLE_GPIO, "LCD enable"); > + return 0; > +} > + > +static void omap3beagle_panel_cleanup(struct lcd_panel *panel) > +{ > + gpio_free(LCD_PANEL_ENABLE_GPIO); > +} > + > +static int omap3beagle_panel_enable(struct lcd_panel *panel) > +{ > + gpio_set_value(LCD_PANEL_ENABLE_GPIO, 1); > + return 0; > +} > + > +static void omap3beagle_panel_disable(struct lcd_panel *panel) > +{ > + gpio_set_value(LCD_PANEL_ENABLE_GPIO, 0); > +} > + > +static unsigned long omap3beagle_panel_get_caps(struct lcd_panel > *panel) > +{ > + return 0; > +} > + > +struct lcd_panel omap3beagle_panel = { > + .name = "omap3beagle", > + .config = OMAP_LCDC_PANEL_TFT, > + > + .bpp = 16, > + .data_lines = 24, > + .x_res = 1024, > + .y_res = 600, > + .hsw = 3, > + .hfp = 3, > + .hbp = 39, > + .vsw = 1, > + .vfp = 2, > + .vbp = 7, > + > + .pixel_clock = 64000, > + > + .init = omap3touchbook_panel_init, > + .cleanup = omap3touchbook_panel_cleanup, > + .enable = omap3touchbook_panel_enable, > + .disable = omap3touchbook_panel_disable, > + .get_caps = omap3touchbook_panel_get_caps, [Hiremath, Vaibhav] Have you compiled this file? Here all references are for omap3touchbook_xxx and the function definitions are defined as omap3beagle_xxx. And again I don't see any change except GPIO pin and LCD height from beagle here, can we try to reuse the driver. Thanks, Vaibhav > +}; > + > +static int omap3touchbook_panel_probe(struct platform_device *pdev) > +{ > + omapfb_register_panel(&omap3beagle_panel); > + return 0; > +} > + > +static int omap3touchbook_panel_remove(struct platform_device > *pdev) > +{ > + return 0; > +} > + > +static int omap3touchbook_panel_suspend(struct platform_device > *pdev, > + pm_message_t mesg) > +{ > + return 0; > +} > + > +static int omap3touchbook_panel_resume(struct platform_device > *pdev) > +{ > + return 0; > +} > + > +struct platform_driver omap3touchbook_panel_driver = { > + .probe = omap3touchbook_panel_probe, > + .remove = omap3touchbook_panel_remove, > + .suspend = omap3touchbook_panel_suspend, > + .resume = omap3touchbook_panel_resume, > + .driver = { > + .name = "omap3touchbook_lcd", > + .owner = THIS_MODULE, > + }, > +}; > + > +static int __init omap3touchbook_panel_drv_init(void) > +{ > + return platform_driver_register(&omap3beagle_panel_driver); > +} > + > +static void __exit omap3touchbook_panel_drv_exit(void) > +{ > + platform_driver_unregister(&omap3touchbook_panel_driver); > +} > + > +module_init(omap3touchbook_panel_drv_init); > +module_exit(omap3touchbook_panel_drv_exit); > -- > 1.6.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux- > omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html