G.N, Vijayakumar said the following on 11/19/2009 05:25 AM:
> >From 3a4213ec9284c04e1a6a3b14094819e70ac951d9 Mon Sep 17 00:00:00 2001
> From: Vijay Kumar <vijaykumar.gn@xxxxxx>
> Date: Thu, 19 Nov 2009 15:06:30 +0530
> Subject: [PATCH 2/3] Correct VDD2 DVFS OPP threshold
>
> VDD2 OPP is linked with VDD1 OPP. THis patch removes hardcoded VDD2 OPP
> values and make threshold generic
>
> Signed-off-by: Vishwanath B.S. <vishwanath.bs@xxxxxx>
> Signed-off-by: Vijay Kumar <vijaykumar.gn@xxxxxx>
> ---
> arch/arm/mach-omap2/resource34xx.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
> index cc85601..3bdb1f9 100644
> --- a/arch/arm/mach-omap2/resource34xx.c
> +++ b/arch/arm/mach-omap2/resource34xx.c
> @@ -372,7 +372,7 @@ int set_opp(struct shared_resource *resp, u32 target_level)
> int ind;
>
> if (resp == vdd1_resp) {
> - if (target_level < 3)
> + if (target_level < MAX_VDD2_OPP)
> resource_release("vdd2_opp", &vdd2_dev);
>
> resource_set_opp_level(VDD1_OPP, target_level, 0);
> @@ -381,7 +381,7 @@ int set_opp(struct shared_resource *resp, u32 target_level)
> * is at 100Mhz or above.
> * throughput in KiB/s for 100 Mhz = 100 * 1000 * 4.
> */
> - if (target_level >= 3)
> + if (target_level > MIN_VDD2_OPP)
> resource_request("vdd2_opp", &vdd2_dev,
> (4 * (l3_opps + MAX_VDD2_OPP)->rate / 1000));
>
> @@ -391,7 +391,7 @@ int set_opp(struct shared_resource *resp, u32 target_level)
> /* Convert the tput in KiB/s to Bus frequency in MHz */
> req_l3_freq = (tput * 1000)/4;
>
> - for (ind = 2; ind <= MAX_VDD2_OPP; ind++)
> + for (ind = MIN_VDD2_OPP; ind <= MAX_VDD2_OPP; ind++)
> if ((l3_opps + ind)->rate >= req_l3_freq) {
> target_level = ind;
> break;
>
IMHO, important catch, but as the previous patch was NAKed (for
MAX_VDDn_OPP), NAK to this too.
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
