"Gopinath, Thara" <thara@xxxxxx> writes: [...] >>> >>>+void omap3_pm_off_mode_enable(int enable) >>>+{ >>>+ struct power_state *pwrst; >>>+ u32 state; >>>+ >>>+ if (enable) >>>+ state = PWRDM_POWER_OFF; >>>+ else >>>+ state = PWRDM_POWER_RET; >>>+ >>>+ list_for_each_entry(pwrst, &pwrst_list, node) { >>>+ pwrst->next_state = state; >>>+ set_pwrdm_state(pwrst->pwrdm, state); > > Shld the next states of MPU and CORE domain also be changed? No. MPU & CORE are handled by CPUidle, and there the enable_off_mode flag is checked. > It should happen only in idle thread or system suspend path. Not at > any arbit point where user sets enable_off_mode. Why not? If the domain is idle, it is turned off immediately. If it's not idle, it doesn't transition until it is. Kevin < -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html