> -----Original Message-----
> From: Gadiyar, Anand
> Sent: Friday, November 13, 2009 10:41 AM
> To: Tony Lindgren; Premi, Sanjeev
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH] omap3: Change the default silicon
>
> Tony Lindgren wrote:
> > * Sanjeev Premi <premi@xxxxxx> [091029 07:35]:
> > > Currently the default silicon - in absence of
> > > identification - is set to OMAP3630 ES1.0.
> > >
> > > Though, condition may/should not arise; but
> > > the default should be latest in the most
> > > common silicon variant - currently OMAP3430
> > > ES3.1.
> >
> > Is this still needed? To me it seems more likely there will
> > more 3630 based silicon than 3430 based silicon?
> >
>
> 3430 ES3.1s are the most common I believe. All boards in the wild
> are 3430 based.
>
> 3630 is just coming up and will take a while to be as common.
>
> IMO, 3430 ES3.1 should be default.
>
> - Anand
[sp] That's exactly the reason for this patch.
There is a small typo in the comment though :(
/* Unknown. Default to latest among all variants */
Should be:
/* Unknown. Default to common among all variants */
Sending a v2 for the same.
~sanjeev
>
>
> > Regards,
> >
> > Tony
> >
> > > Signed-off-by: Sanjeev Premi <premi@xxxxxx>
> > > ---
> > > arch/arm/mach-omap2/id.c | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > > index 1c15112..0162623 100644
> > > --- a/arch/arm/mach-omap2/id.c
> > > +++ b/arch/arm/mach-omap2/id.c
> > > @@ -243,8 +243,8 @@ void __init omap3_check_revision(void)
> > > }
> > > break;
> > > default:
> > > - /* Unknown default to latest silicon rev as default*/
> > > - omap_revision = OMAP3630_REV_ES1_0;
> > > + /* Unknown. Default to latest among all variants */
> > > + omap_revision = OMAP3430_REV_ES3_1;
> > > }
> > > }
> > >
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
