RE: Query: Regulator framework in EHCI driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Brown wrote:
> On Wed, Nov 04, 2009 at 06:02:48PM +0530, Gupta, Ajay Kumar wrote:
> 
> > > You should be able to regulator_get() the 1v8 supply and
> > > regulator_enable() it. The regulator was already setup in twl4030-core.c
> > > so that should work just fine. 
> 
> > I can do regulator_get() and regulator_enable() but where ? Are you referring to board file?
> 
> > I was thinking of doing it in a generic form within EHCI driver (ehci-omap.c).
> 
> Do it in the EHCI driver.  The EHCI driver should just unconditionally
> use the regulators, the regulator API will be compiled out if support is
> disabled in Kconfig.
> 

NAK to do it unconditionally in the driver. This is board specific.
It just so happens that this is the regulator used on the beagleboard
and EVM, but it could very easily be another one (like on the SDP).

How about a hook from the platform code in mach-omap2/usb-ehci.c instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux