RE: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] 
> Sent: Wednesday, November 04, 2009 3:35 AM
> To: Premi, Sanjeev
> Cc: Reddy, Teerth; linux-omap@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
> 
> "Premi, Sanjeev" <premi@xxxxxx> writes:
> 
> >> -----Original Message-----
> >> From: linux-omap-owner@xxxxxxxxxxxxxxx 
> >> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman
> >> Sent: Thursday, August 27, 2009 1:55 PM
> >> To: Reddy, Teerth
> >> Cc: linux-omap@xxxxxxxxxxxxxxx
> >> Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
> >> 
> >> Hi Teerth,
> >> 
> >> "Reddy, Teerth" <teerth@xxxxxx> writes:
> >> 
> >> > From : Teerth Reddy <teerth@xxxxxx>
> >> >
> >> > This patch changes for setting the padconf value for 
> sys_nirq line
> >> > which is connected to T2 INTR1.  This will fix the T2 
> keypad wakeup
> >> > issue on OMAP3 SDP.
> >> >
> >> > Signed-off-by: Teerth Reddy < teerth@xxxxxx >
> >> 
> >> Patch looks good, thanks.  I'll pull this into PM branch and queue
> >> in my PM fixes queue for next merge window.
> >> 
> >> I did a minor update by adding a comment in the
> >> enable_board_wakeup_source function stating that this is the
> >> interrupt pin used for T2.
> >> 
> >> Kevin
> >> 
> >
> > Teerth, Kevin,
> >
> > Did you test it with OFF mode enabled?
> 
> I tested on SDP, but not on omap3evm since that was the only board
> file touched by this patch.
> 
> > When I do "echo 1 > /sys/power/enable_off_mode" I don't see 
> resume on the omap3evm.
> >
> > Schematics for the keypad are/seem to be same for EVM and SDP.
> 
> I'm guessing that it's because the patch from Teerth only muxes this
> pin for the SDP.  I'm guessing that doing the same omap_cfg_reg in the
> OMAP3EVM board file will get this working.
> 
> Kevin
> 

Kevin,

I have done the corresponding changes. See:
 1) http://marc.info/?l=linux-omap&m=125725494430834&w=2
 2) http://marc.info/?l=linux-omap&m=125725495630852&w=2
 3) http://marc.info/?l=linux-omap&m=125725498430876&w=2

If I do suspend with OFF mode enabled (enable_off_mode=1), and
all power domains transition to target state, the key press
doesn't resume the system.

But, with this flag off OR any poer domain didn't transition to
the target state. The key press brings system out of 'suspend'.

Best regards,
Sanjeev

> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux