Nishanth >-----Original Message----- >From: Menon, Nishanth >> From: Pandita, Vikram >> >From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Pais, >> >Sent: Monday, October 26, 2009 4:40 PM >> >To: Pais, Allen; linux-omap@xxxxxxxxxxxxxxx >> >Subject: RE: [PATCH 1/2] Added board-3630.c file. >> >> >> Signed-off-by: Allen Pais <allen.pais@xxxxxx> >> >> --- >> >> arch/arm/mach-omap2/board-3630sdp.c | 188 >> >> +++++++++++++++++++++++++++++++++++ >> >> 1 files changed, 188 insertions(+), 0 deletions(-) create mode >> >> 100644 arch/arm/mach-omap2/board-3630sdp.c >> >> >> >> diff --git a/arch/arm/mach-omap2/board-3630sdp.c b/arch/arm/mach- >> >> omap2/board-3630sdp.c new file mode 100644 index 0000000..d3ddbd1 >> >> --- /dev/null >> >> +++ b/arch/arm/mach-omap2/board-3630sdp.c >> >> @@ -0,0 +1,188 @@ >> >> +/* >> >> + >> > >> >NAK. Could we follow the same issue with zoom2 -> break the keypad into a >> Separate one and use it >> >instead? Same for all reused zoom2 components.. >> > >> >[Allen] Yes, we should do that. Not only for keypad but also >> >For display panel and touch screen so that sdp3630, zoom3 and >> >Zoom2 could use the same code, without having to duplicate >> >Code. >> >> We just got the same image for zoom3 boot on SDP3630 (after mach-type >> change) >> The peripheral set is almost >90% same: same keypad, same display, same >> RAM, same NAND. >Ok zoom2,zoom3,sdp3630 -> might be good to compare. Here is a quick attempt: >Peripheral zoom2 zoom3 sdp3630 I was making that list already. Good to see you thinking on same lines. However your list does not match with mine and I tried to confirm the changes looking at h/w. Here is the list, in the order of impact: Peripheral zoom2 zoom3 sdp3630 Ethernet A A B **(may not be same) NOR n/a n/a B ** different Onenand n/a n/a B ** diffferent HDMI A A B **(Need to verify: not there on i2c3) NAND A A A (same nand) SDRAM A A A (same sdram) Keypad A A A (same twl) Camera A A A (same sensor can be mounted: can check further) LCD Display A A A (same wvga display) Power A A A (same chip level) Audio A A A (its the same) Voltage resources?? (not sure what you mean?) LEDs A A B (LEDs are board specific, can reside in separate board file) OPPs A A A (same chip feature) >.... others?? ... >NOTE: I am just using A and B to show the types of devices. So the files registering the same type >would probably be shared.. could you expand this list? > >> >> I see a good amount of re-use possible here. >> Here is how we could do it: >> >> Board-zoom2.c >> Split into: >> Board-zoom2.c >> Board-zoom-peripheral.c [reuse] >> >> 3630 zoom3 uses: >> Board-zoom3.c >> Board-zoom-peripheral.c [reuse] >> >> 3630 SDP uses: >> Board-3630sdp.c >> Board-zoom-peripheral.c [reuse] >> >> >> Will give a first pass at this split up and post patches. >> >Thanks.. > >Regards, >Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
