> -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx] > Sent: Wednesday, October 28, 2009 10:29 PM > To: Premi, Sanjeev > Cc: Balbi Felipe (Nokia-D/Helsinki); > linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx > Subject: Re: [PATCH 1/2] AM35xx: Runtime detection of the device > > Hi, > > On Wed, Oct 28, 2009 at 01:40:04PM +0100, ext Premi, Sanjeev wrote: > > > case 0xb891: > > > - /* Handle 36xx devices */ > > > - switch (rev) { > > > - case 0: > > > - omap_revision = OMAP3630_REV_ES1_0; > > > - break; > > > - default: > > > - /* Use the latest known revision as default */ > > > - omap_revision = OMAP3630_REV_ES1_0; > > > - } > > > - break; > > > + /* FALLTHROUGH */ > > > default: > > > /* Unknown default to latest silicon rev as default*/ > > > omap_revision = OMAP3630_REV_ES1_0; > > > > [sp] Haven't applied the patch. But, if FALLTHROUGH will > make the device > > detected as OMAP3630, then it may not be right. The > fall through > > should be on most common device. OMAP3430 ES21./3.1 > should be ideal. > > > > Thoughts? > > see that I didn't change the default clause. It was already > OMAP3630_REV_ES1_0. If it has to be anything else, the > default should be > changed and the case 0xb891: should do: I did see that. But since you were already proposing a change thought it would be good idea. ~sanjeev > > case 0xb891: > omap_revision = OMAP3630_REV_ES1_0; > break; > > -- > balbi > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
