On Tue, 13 Oct 2009, Kevin Hilman wrote: > "Dasgupta, Romit" <romit@xxxxxx> writes: > > > (Tested on Zoom2). > > > > 'omap_pm_dsp_set_min_opp' & 'omap_pm_cpu_set_freq' were using their own > > struct device *. This is a problem because invoking these functions from > > different clients would result in setting of the resource level as requested by > > the last caller. Fixes this by introducing a struct device * to the parameter > > list for these functions. > > Signed-off-by: Romit Dasgupta <romit@xxxxxx> > > > This looks like the right fix to me. > > Paul, any comments? Wait a minute, I am retracting my ack. Romit, the only caller of omap_pm_dsp_set_min_opp() should be DSPBridge and the only caller of omap_pm_cpu_set_freq() should be CPUFreq. So the struct device * pointer is not necessary, unless I am missing something. Can you please explain what you're trying to do? - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html