On Tuesday 20 October 2009 13:03:34 ext Mark Brown wrote: > On Mon, Oct 19, 2009 at 03:42:17PM +0300, Peter Ujfalusi wrote: > > New MFD child to twl4030 MFD device. > > This MFD device will be used by the drivers, which needs resources > > from the twl4030 codec like audio and vibra. > > > > The platform specific configuration data is passed along to the > > child drivers (audio, vibra). > > > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> > > > > +config TWL4030_CODEC > > + bool "Support codec part of the TWL4030 family chips" > > This seems like something that users shouldn't really have to worry > about selecting explicitly - might it be better to have it selected by > the drivers that use it instead? It feels like it's an implementation > detail of the driver. Yes, first I had the TWL4030_CODEC selected in the sound/soc/codecs/Kconfig, but for some reason I have decided to add user selectable config option instead and use the depends on in the codecs Makefile. I'll make the change as you suggested. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
