>-----Original Message----- >From: Woodruff, Richard >Sent: Monday, October 19, 2009 5:18 PM >To: Pandita, Vikram; linux-omap@xxxxxxxxxxxxxxx >Cc: Menon, Nishanth >Subject: RE: [PATCH] omap: 3630: update is_chip variable > > >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Pandita, Vikram >> Sent: Monday, October 19, 2009 4:58 PM > >> diff --git a/arch/arm/plat-omap/include/mach/cpu.h b/arch/arm/plat- >> omap/include/mach/cpu.h >> index 7cb0556..05a0a33 100644 >> --- a/arch/arm/plat-omap/include/mach/cpu.h >> +++ b/arch/arm/plat-omap/include/mach/cpu.h >> @@ -454,6 +454,7 @@ IS_OMAP_TYPE(3430, 0x3430) >> #define CHIP_IS_OMAP3430ES2 (1 << 4) >> #define CHIP_IS_OMAP3430ES3_0 (1 << 5) >> #define CHIP_IS_OMAP3430ES3_1 (1 << 6) > >Should we add a little space for 3430 to grow? Current TRM already defines a 3.1.2. For this version >changes are transparent to software. IIRC mostly internal cell tweaks to allow for expanded >operating range. > >The CONTROL.CONTROL_IDCODE value is 0x0B6D 602F for OMAP34xx ES1.0. >The CONTROL.CONTROL_IDCODE value is 0x1B7A E02F for OMAP34xx ES2.0. >The CONTROL.CONTROL_IDCODE value is 0x2B7A E02F for OMAP34xx ES2.1. >The CONTROL.CONTROL_IDCODE value is 0x3B7A E02F for OMAP34xx ES3.0. >The CONTROL.CONTROL_IDCODE value is 0x4B7A E02F for OMAP34xx ES3.1. >The CONTROL.CONTROL_IDCODE value is 0x7B7A E02F for OMAP34xx ES3.1.2. > >> +#define CHIP_IS_OMAP3630ES1 (1 << 7) In that case we have to be careful. "arch/arm/plat-omap/include/mach/cpu.h" struct omap_chip_id { u8 oc; u8 type; }; Type is u8 and we already are using the 8th bit now (1<<7) So a type u8 -> u16 will also be needed. > >Its hard to guess how many more will come. Ideally it will be 3630 which is growing from this point >on. It is faster/smaller/cheaper along with some bug fixes. > >Regards, >Richard W. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
