* Shilimkar, Santosh <santosh.shilimkar@xxxxxx> [091014 21:40]: > > -----Original Message----- > > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > > Sent: Wednesday, October 14, 2009 10:36 PM > > To: Shilimkar, Santosh > > Cc: linux-omap@xxxxxxxxxxxxxxx; S, Venkatraman; Hari n; Jarkko Nikula > > Subject: Re: [PATCH] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel > > linking > > > > * Santosh Shilimkar <santosh.shilimkar@xxxxxx> [091013 23:14]: > > > OMAP sDMA driver API omap_stop_dma() doesn't really stop the dma when > > used > > > in linking scenario. This patch fixes the same. > > > > To me it looks like this will break things for omap1 as the DMA channel > > interrupt is not disabled first. I guess the fix is to move the > > "Disable all interrupts on the channel" part above clearing the > > link mappings. > Indeed it will break OMAP1. Initially I thought of putting this change at this place so that it takes care of both normal and linking scenario. > > I will rework this and send v2. OK, thanks. > > This fix should be tested in linux-omap before we send this to mainline. > Yes ofcourse. That what I meant by merge. Yeah, we should still have enough time to get it into mainline kernel as a fix during this -rc cycle. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
