Charu, > -----Original Message----- > From: Peter Ujfalusi [mailto:peter.ujfalusi@xxxxxxxxx] > Sent: Thursday, October 15, 2009 12:56 PM > To: Shilimkar, Santosh > Cc: Varadarajan, Charu Latha; linux-omap@xxxxxxxxxxxxxxx; Syed, Rafiuddin > Subject: Re: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg > access > > On Thursday 15 October 2009 09:10:54 ext Shilimkar, Santosh wrote: > > > > > > > - writew(buf, base + OMAP_MCBSP_REG_DXR1); > > > > > > > + OMAP_MCBSP_WRITE(base, DXR, buf); > > > > > > > > > > > > Why do you need this? Is writew()/readw() not doing 16 bit > > > > > > operations ? > > > > > > > > > > The intension is to use 32 bit access and not 16 bit access > > > > > > > > Use readl() / writel() then. > > > > > > Yes, OMAP_MCBSP_WRITE macro makes use of readl() / writel() for OMAP3 > > > > Good!! Then get rid of this macro and directly use kernel standard > > API- readl() / writel() -- > > Well, OMAP1 and OMAP2 still has 16 bit registers in McBSP. Please look at this comment from Peter. So please reconsider your patch and decision of changing the signature of the API since it breaks OMAP1 and OMAP2. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
