Artem Bityutskiy <dedekind1@xxxxxxxxx> writes: > On 10/01/2009 10:01 AM, Artem Bityutskiy wrote: >> From: Artem Bityutskiy<Artem.Bityutskiy@xxxxxxxxx> >> >> The 'pwrdm_for_each()' function walks powerdomains with a spinlock >> locked, so the the callbacks cannot do anything which may sleep. >> This patch introduces a 'pwrdm_for_each_nolock()' helper which does >> the same, but without the spinlock locked. This fixes the following >> lockdep warning: >> >> [ 0.000000] WARNING: at kernel/lockdep.c:2460 lockdep_trace_alloc+0xac/0xec() >> [ 0.000000] Modules linked in: >> (unwind_backtrace+0x0/0xdc) from [<c0045464>] (warn_slowpath_common+0x48/0x60) >> (warn_slowpath_common+0x48/0x60) from [<c0067dd4>] (lockdep_trace_alloc+0xac/0xec) >> (lockdep_trace_alloc+0xac/0xec) from [<c009da14>] (kmem_cache_alloc+0x1c/0xd0) >> (kmem_cache_alloc+0x1c/0xd0) from [<c00b21d8>] (d_alloc+0x1c/0x1a4) >> (d_alloc+0x1c/0x1a4) from [<c00a887c>] (__lookup_hash+0xd8/0x118) >> (__lookup_hash+0xd8/0x118) from [<c00a9f20>] (lookup_one_len+0x84/0x94) >> (lookup_one_len+0x84/0x94) from [<c010d12c>] (debugfs_create_file+0x8c/0x20c) >> (debugfs_create_file+0x8c/0x20c) from [<c010d320>] (debugfs_create_dir+0x1c/0x20) >> (debugfs_create_dir+0x1c/0x20) from [<c000e8cc>] (pwrdms_setup+0x60/0x90) >> (pwrdms_setup+0x60/0x90) from [<c002e010>] (pwrdm_for_each+0x30/0x80) >> (pwrdm_for_each+0x30/0x80) from [<c000e79c>] (pm_dbg_init+0x7c/0x14c) >> (pm_dbg_init+0x7c/0x14c) from [<c00232b4>] (do_one_initcall+0x5c/0x1b8) >> (do_one_initcall+0x5c/0x1b8) from [<c00083f8>] (kernel_init+0x90/0x10c) >> (kernel_init+0x90/0x10c) from [<c00242c4>] (kernel_thread_exit+0x0/0x8) >> >> Signed-off-by: Artem Bityutskiy<Artem.Bityutskiy@xxxxxxxxx> > > I guess this patch was actually for Tony, as this warning is seen on l-o. > Tony, any plans to pick this up? Actually, I'll queue this in my PM fixes queue for the -rc series. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
