Hi Santosh On Sat, 3 Oct 2009 03:56:51 +0530 "Shilimkar, Santosh" <santosh.shilimkar@xxxxxx> wrote: > @@ -1000,10 +1005,6 @@ void omap_stop_dma(int lch) > if (cpu_class_is_omap1()) > dma_write(0, CICR(lch)); > It's better to move this interrupt disable line for omap1 as well with the lines below for preventing any potential race. > - l = dma_read(CCR(lch)); > - l &= ~OMAP_DMA_CCR_EN; > - dma_write(l, CCR(lch)); > - > dma_chan[lch].flags &= ~OMAP_DMA_ACTIVE; > } I tested your patch on Beagle with 'moc (music on console)' player and it's fixing one issue I just found. Without your patch there is sometimes short bursts of white noise if I toggle the pause continuously. No idea how the noise is inducing there but patch is fixing that too. -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
