Re: [PATCH] omap_hsmmc: Add missing probe handler hook to platform driver data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ext Rok Markovič wrote:
This is not the correct way to do it. There was some conflict during merge in init function. Correct patch should look like this:

--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
 static int __init omap_hsmmc_init(void)
 {
        /* Register the MMC driver */
-       return platform_driver_register(&omap_hsmmc_driver);
+       return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
 }

 static void __exit omap_hsmmc_cleanup(void)

Rok


Oh yes. Since omap_hsmmc is not a hot-pluggable device.
Will send a v2.

Thanks Rok, for pointing this out.



Dne četrtek 1. oktobra 2009 ob 16:39:13 ste napisali:
The missing probe handler hook will never probe the driver. Add it back.
Fixes broken MMC on OMAP.

Signed-off-by: Roger Quadros <ext-roger.quadros@xxxxxxxxx>
---
 drivers/mmc/host/omap_hsmmc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..26abe1e 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2001,6 +2001,7 @@ clk_en_err:
 #endif

 static struct platform_driver omap_hsmmc_driver = {
+	.probe		= omap_hsmmc_probe,
 	.remove		= omap_hsmmc_remove,
 	.suspend	= omap_hsmmc_suspend,
 	.resume		= omap_hsmmc_resume,


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux