Re: [DSPBRIGDE PATCH 6/6] dsp: bridge: beautify erro path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Aug 31, 2009 at 09:50:30PM +0200, ext Guzman Lugo, Fernando wrote:
> >As far as I see this is not the dsp status but just a word to collect
> >errors. More logical in this piece of your code is to use result word
> >instead of status.
> 
> Maybe you did not see far enough, but variable initStatus it the one use to
> store DSPBridge errors, the variable status is use to collect the status
> from calls to kernel functions. So I think we don't need two variables to
> collect error from kernel, so we should use one, it could be status or
> results it does not matters. What do you think?

yes, this has to be cleaned up, but it should be an extra patch and not
in this one.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux