Hi, >-----Original Message----- >From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] >Sent: Saturday, August 29, 2009 2:19 AM >To: Guzman Lugo, Fernando >Cc: Felipe Balbi; Hiroshi DOYU; Ameya Palande; Linux OMAP Mailing List >Subject: Re: [DSPBRIGDE PATCH 6/6] dsp: bridge: beautify erro path > >On Sat, Aug 29, 2009 at 1:31 AM, Guzman Lugo, Fernando<x0095840@xxxxxx> >wrote: > >>>result = status, isn't is? >>>or change status to result on previous lines. >> Yes, we need to assigned status to result, in order to report the error, >however I think we can get rid of result and use status instead, what do >you think? > >As far as I see this is not the dsp status but just a word to collect >errors. More logical in this piece of your code is to use result word >instead of status. Maybe you did not see far enough, but variable initStatus it the one use to store DSPBridge errors, the variable status is use to collect the status from calls to kernel functions. So I think we don't need two variables to collect error from kernel, so we should use one, it could be status or results it does not matters. What do you think? Regards, Fernando. > >-- >With Best Regards, >Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
