Vikram, > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Pandita, Vikram > Sent: Tuesday, August 25, 2009 11:54 PM > To: Varadarajan, Charu Latha; linux-omap@xxxxxxxxxxxxxxx > Cc: tony@xxxxxxxxxxx; david-b@xxxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; > p_gortmaker@xxxxxxxxx; Varadarajan, Charu Latha > Subject: RE: [PATCH v2 4/4] RTC MSECURE: mux configuration in board files > > Charu > > >-----Original Message----- > >From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of > >charu@xxxxxx > >Sent: Monday, August 24, 2009 10:08 AM > >To: linux-omap@xxxxxxxxxxxxxxx > >Cc: tony@xxxxxxxxxxx; david-b@xxxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; > p_gortmaker@xxxxxxxxx; Varadarajan, > >Charu Latha > >Subject: [PATCH v2 4/4] RTC MSECURE: mux configuration in board files > > > > > > static struct i2c_board_info __initdata sdp2430_i2c_boardinfo[] = { > >diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board- > 3430sdp.c > >index 351e8c5..1bb79f5 100644 > >--- a/arch/arm/mach-omap2/board-3430sdp.c > >+++ b/arch/arm/mach-omap2/board-3430sdp.c > >@@ -54,7 +54,7 @@ > > #define ENABLE_VAUX3_DEDICATED 0x03 > > #define ENABLE_VAUX3_DEV_GRP 0x20 > > > >-#define TWL4030_MSECURE_GPIO 22 > >+#define TWL4030_MSECURE_GPIO 22 > > > > static int sdp3430_keymap[] = { > > KEY(0, 0, KEY_LEFT), > >@@ -574,8 +574,24 @@ static inline void board_smc91x_init(void) > > > > #endif > > > >+int sdp3430_rtc_init(void) > >+{ > >+ struct twl4030_rtc_platform_data sdp3430_rtc_data; > >+ /* msecure mux cfg */ > >+ if (omap_type() == OMAP2_DEVICE_TYPE_GP && > >+ omap_rev() < OMAP3430_REV_ES2_0) { > > What happens to msecure line on SDP/LDP with ES2.0 and above? The default value is NULL, hence no need to reinitialize. FYI, the patch was tested on SDP boards with greater than ES2.0 version silicon. > > Is it that Triton MSECURE line gets pulled up by default, and hence no need > for the patch? > Msecure initialization is not required for such boards. > > >+ sdp3430_rtc_data.msecure_gpio = TWL4030_MSECURE_GPIO; > >+ sdp3430_twldata.rtc = &sdp3430_rtc_data; > >+ return omap_cfg_reg(AF9_34XX_V1_X_GPIO22_OUT); > >+ } else > >+ return 0; > >+}; > >+ > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html p-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html