Vikram, > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Pandita, Vikram > Sent: Wednesday, August 26, 2009 12:01 AM > To: Varadarajan, Charu Latha; linux-omap@xxxxxxxxxxxxxxx > Cc: tony@xxxxxxxxxxx; david-b@xxxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; > p_gortmaker@xxxxxxxxx > Subject: RE: [PATCH v2 2/4] RTC MSECURE: msecure initialization > > Charu -- possible bug > > >-----Original Message----- > >From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of > >Varadarajan, Charu Latha > > /* > >+ * msecure line initialisation for TWL4030 RTC registers write access > >+ */ > >+static int msecure_init(struct twl4030_rtc_platform_data *pdata) > >+{ > >+ int ret = 0; > >+ if (pdata == NULL) > >+ goto out; > >+ > >+ ret = gpio_request(pdata->msecure_gpio, "msecure"); > > What about other boards like: Beagle, EVM, Pandora, Zoom2, RX51 > What about SDP/LDP with OMAP ES2.1 and above > > For these boards, there is no msecure_gpio defined. > > What would be the value for msecure_gpio for these boards? For the twl4030 based boards which don't have msecure gpio lines, the rtc platform data need to be null. The same was addressed in version 1 patch and it has been agreed that the default value is NULL and hence need not be initialized in board files. This patch is tested on SDP boards with silicon version 3.1. > > > >+ if (ret) { > >+ pr_err("twl4030_rtc: can't reserve msecure GPIO:%d !\n" > >+ "RTC functionality will not be available\n", > >+ pdata->msecure_gpio); > >+ goto out; > >+ } > >+ /* > >+ * TWL4030 will be in secure mode if msecure line from OMAP is low. > >+ * Make msecure line high in order to change the TWL4030 RTC time > >+ * and calender registers. > >+ */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
