Re: [PATCH 2/2] OMAP: remove OMAP_TAG_UART

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [090824 15:58]:
> Grazvydas Ignotas <notasas@xxxxxxxxx> writes:
> 
> > On Mon, Aug 24, 2009 at 10:41 AM, Kevin
> > Hilman<khilman@xxxxxxxxxxxxxxxxxxx> wrote:
> >> Kalle Valo <kalle.valo@xxxxxx> writes:
> >>
> >>> Omap tags are deprecrated and convert all OMAP_TAG_UART cases to use
> >>> omap_uart_platform_data instead.
> >>>
> >>> Tested on rx51 and n8x0. Compile tested on omap_osk_5912.
> >>>
> >>> Signed-off-by: Kalle Valo <kalle.valo@xxxxxx>
> >>
> >> Rather than converting all the omap_uart_configs into platform_data.
> >> Any objections to just dropping the platform_data all together?
> >>
> >> This is only used for selecting which UARTs to enable at boot time,
> >> and all the board files simply enable all the UARTs.
> >
> > Pandora wasn't enabling all UARTs, as did some other off-tree board
> > (someone was posting UART questions on this list). This meant that
> > UART3 was appearing as ttyS0 here, and after this patch it will appear
> > as ttyS2, which means we will have to update our boot scripts. Not a
> > huge deal but I'd prefer retaining platform_data.
> 
> I think your boot scripts should be fixed.
> 
> Your problem actually points out another justification for my patch.
> Having all the UARTs enabled means that the ttyS* names will be
> consistent across multiple boards and result in much more portable
> userspace init.

Great, finally! The shifting of the UART numbering has been driving me
crazy for years now. Will buy Kevin a pint.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux