Re: [PATCH 2/2] OMAP: remove OMAP_TAG_UART

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 24, 2009 at 10:41 AM, Kevin
Hilman<khilman@xxxxxxxxxxxxxxxxxxx> wrote:
> Kalle Valo <kalle.valo@xxxxxx> writes:
>
>> Omap tags are deprecrated and convert all OMAP_TAG_UART cases to use
>> omap_uart_platform_data instead.
>>
>> Tested on rx51 and n8x0. Compile tested on omap_osk_5912.
>>
>> Signed-off-by: Kalle Valo <kalle.valo@xxxxxx>
>
> Rather than converting all the omap_uart_configs into platform_data.
> Any objections to just dropping the platform_data all together?
>
> This is only used for selecting which UARTs to enable at boot time,
> and all the board files simply enable all the UARTs.

Pandora wasn't enabling all UARTs, as did some other off-tree board
(someone was posting UART questions on this list). This meant that
UART3 was appearing as ttyS0 here, and after this patch it will appear
as ttyS2, which means we will have to update our boot scripts. Not a
huge deal but I'd prefer retaining platform_data.

> Also, selective
> enable is no longer needed since UART core has an inactivity timer
> which will disable clocks after inactivity anyways.
>
> I just posted a patch which does this:
>
>  http://patchwork.kernel.org/patch/43516/
>
> If others are OK with this, it can be folded into original patch
> before going upstream via Tony's for-next.
>
> Kevin
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux