Hi Andreas,
On Tue, Sep 3, 2024 at 2:34 PM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
> Am Mon, 2 Sep 2024 15:53:07 +0200
> schrieb Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> > On Mon, Jun 3, 2024 at 11:41 PM Andreas Kemnade
> > <andreas@xxxxxxxxxxxx> wrote:
> > > just stumbled across this on 6.10-rc1:
> > >
> > > [ 1.475830] ocp:target-module@48210000:mpu:fck: device ID is
> > > greater than 24 [ 1.483154] ti-sysc ocp:target-module@48210000:
> > > could not add child clock fck: -12
> >
> > And on boneblack:
> >
> > 48000000.interconnect:segment@200000:target-module@0:mpu@0:fck: device
> > ID is greater than 24
> > target-module@4b000000:target-module@140000:pmu@0:fck: device ID is
> > greater than 24
> >
> > > Maybe
> > > /*
> > > * Use clkdev_add() instead of clkdev_alloc() to avoid the
> > > MAX_DEV_ID
> > > * limit for clk_get(). If cl ever needs to be freed, it
> > > should be done
> > > * with clkdev_drop().
> > > */
> > > in ti-sysc.c does not work anymore?
> > >
> > > The offending clock definition is in omap4.dtsi
> > >
> > > clocks = <&mpuss_clkctrl OMAP4_MPU_CLKCTRL 0>;
> > >
> > > Did not bisect that yet.
> >
> > Commit 8d532528ff6a6b1b ("clkdev: report over-sized strings when
> > creating clkdev entries") in v6.10-rc1, with follow-up commit
> > 616501eccb58615f ("clkdev: don't fail clkdev_alloc() if over-sized")
> > in v6.10-rc4.
> >
> > I have no idea if these clkdev registrations are still necessary/used.
> >
> well, it might explain some mystery behavior in the past. Lets
> see where it comes from. As the comment says, there should be a
> workaround against that limitation. So the problem should not be there
> in the first place. I have some strange problems with
> clk_disable_unused.
>
> I first thought it is a id < 24 issue and not a strlen(something) < 24.
Me too :-(
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
