On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> From: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>
> Add suspend and resume support for rc mode.
Same comments as for earlier patches.
Since it's wide, please, check the whole series for the same issues
and address them.
...
> + if (pcie->reset_gpio)
Dup, why?
> + gpiod_set_value_cansleep(pcie->reset_gpio, 0);
...
> + if (pcie->reset_gpio) {
> + usleep_range(100, 200);
fsleep() ?
Btw, why is it needed here, perhaps a comment?
> + gpiod_set_value_cansleep(pcie->reset_gpio, 1);
> + }
...
> + ret = cdns_pcie_host_setup(rc, false);
> + if (ret < 0) {
> + clk_disable_unprepare(pcie->refclk);
> + return -ENODEV;
Why is the error code being shadowed?
> + }
...
> +#define cdns_pcie_to_rc(p) container_of(p, struct cdns_pcie_rc, pcie)
Is container_of.h included in this file?
...
> @@ -381,7 +383,6 @@ struct cdns_pcie_ep {
> unsigned int quirk_disable_flr:1;
> };
>
> -
> /* Register access */
> static inline void cdns_pcie_writel(struct cdns_pcie *pcie, u32 reg, u32 value)
> {
Stray change.
--
With Best Regards,
Andy Shevchenko
