Re: [PATCH 13/14] PCI: j721e: move reset GPIO to device struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
> From: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> Move reset GPIO to device struct, so it can be used at suspend and
> resume stages.


> -       struct gpio_desc *gpiod;

You can leave this and make the patch much lighter.


>                         if (ret != -EPROBE_DEFER)
>                                 dev_err(dev, "Failed to get reset GPIO\n");

Side note (not related to this change): perhaps dev_err_probe()?

With Best Regards,
Andy Shevchenko

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux