On Wed, Aug 12, 2009 at 03:18:49PM +0300, Tony Lindgren wrote:
> + if (mmc_controller->slots[0].wires == 8)
> + printk(KERN_WARNING
> + "\n MMC2: DAT4, DAT5, DAT6, DAT7: "
> + "Setup the mux in board file");
> + }
> + if (controller_nr == 2) {
> + /* MMC3 */
> + printk(KERN_WARNING
> + "\n MMC3: Setup the mux in board file: "
> + "Multiple options exist, so is board specific");
> + }
Having printks which issue a level, followed by a newline, message and
omitting the newline at the end looks really wrong:
- firstly, the KERN_WARNING "\n" line creates a blank line in the kernel
message log.
- the message itself will be at the kernels default message level
- the following kernel message will be appended to the end, with any
level tag exposed.
So I think the above printk statements are completely wrong and broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
