On Fri, Aug 18, 2023 at 05:30:17PM +0800, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for > prepared and enabled clocks"), devm_clk_get_optional() and > clk_prepare_enable() can now be replaced by > devm_clk_get_optional_enabled() when the driver enables (and possibly > prepares) the clocks for the whole lifetime of the device. Moreover, > it is no longer necessary to unprepare and disable the clocks explicitly. ... > if (IS_ERR(chip->clk)) > - return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), "input clock not found.\n"); > + return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), > + "input clock not found or failed to prepare clk\n"); Don't alter message in this change. ... Do you need to set driver data now? -- With Best Regards, Andy Shevchenko