On Fri, Aug 18, 2023 at 05:30:16PM +0800, Li Zetao wrote:
> Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for
> prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable()
> can now be replaced by devm_clk_get_enabled() when the driver enables
> (and possibly prepares) the clocks for the whole lifetime of the device.
> Moreover, it is no longer necessary to unprepare and disable the clocks
> explicitly.
...
> ret = devm_gpiochip_add_data(&pdev->dev, &chip->gc, chip);
> - if (ret) {
> - clk_disable_unprepare(clk);
> + if (ret)
> return ret;
> - }
>
> dev_info(&pdev->dev, "Init done\n");
Go further and simply
return devm_gpiochip_add_data(...);
--
With Best Regards,
Andy Shevchenko
