RE: [PATCH 2/6] ARM: OMAP4: PM: PRM/CM module offsets for OMAP4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paul, 

>-----Original Message-----
>From: Paul Walmsley [mailto:paul@xxxxxxxxx] 
>Sent: Wednesday, August 12, 2009 10:17 AM
>To: Shilimkar, Santosh
>Cc: Nayak, Rajendra; linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx; 
>linux-omap@xxxxxxxxxxxxxxx; Cousson, Benoit; sakari.poussa@xxxxxxxxx
>Subject: RE: [PATCH 2/6] ARM: OMAP4: PM: PRM/CM module offsets 
>for OMAP4
>
>Hello Santosh,
>
>On Wed, 12 Aug 2009, Shilimkar, Santosh wrote:
>
>> > I'd also like to see the full names of the PRCM submodules, e.g.,
>> > 
>> > OMAP4430_CM2_RESTORE_CM2_MOD
>> > 
>> > rather than just
>> > 
>> > OMAP4430_CM2_RESTORE_MOD
>> 
>> Not sure what you mean by __full__ name here. You are adding 
>a redundant CM2 in the name here.
>
>Yes, for the above example, it looks pretty redundant, doesn't 
>it.  But 
>what about:
>
>OMAP4430_PRM_WKUP_CM_MOD 

There are only 2 such instances of these where in WKUP_CM and EMU_CM and
part of PRM module. There are no such instances in CM1 or CM2.
To take care of 2 of these we would have 60 odd which would look redundant
and module names as along as this OMAP4430_PRM_ALWAYS_ON_PRM_MOD.

If its really confusing and hard to remember that these belong to PRM we can always 
have exceptions in naming, and we have had exceptions in
3430 as well. There are modules common to 2430/3430 which are named differently
as well as modules only in ES2 which are named differently.

>
>As my original message mentioned.
>
>Do you still feel that is redundant?
>
>
>- Paul
>
>--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux