On Tue, 11 Aug 2009, Paul Walmsley wrote: > On Mon, 10 Aug 2009, Rajendra Nayak wrote: > > > diff --git a/arch/arm/mach-omap2/prcm-common.h b/arch/arm/mach-omap2/prcm-common.h > > index cb1ae84..ab0dd8e 100644 > > --- a/arch/arm/mach-omap2/prcm-common.h > > +++ b/arch/arm/mach-omap2/prcm-common.h ... > > +#define OMAP4430_WKUP_MOD 0x1700 > > +#define OMAP4430_WKUP_CM_MOD 0x1800 > > +#define OMAP4430_EMU_MOD 0x1900 > > +#define OMAP4430_EMU_CM_MOD 0x1A00 ... > 2. It would be better to infix the module name in these, e.g., > OMAP4430_CM2_INSTR_MOD (and add PRM, CM1 variants) rather than > just OMAP4430_INSTR_MOD. One other comment on macros like the above: it would also be best to use the full PRM/CM submodule name. So, for instance, use OMAP4430_PRM_EMU_PRM_MOD and OMAP4430_PRM_EMU_CM_MOD. This is to avoid any potential confusion caused by having to remember a rule like "when the PRCM submodule name ends in _PRM, drop the _PRM". One can just use the name from the TRM, always prefixed with the module name, and suffixed with _MOD (or whatever). The gen_prcm44xx.py script will generate these in this format. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
