On Tue, May 16, 2023 at 5:52 PM Aaro Koskinen <aaro.koskinen@xxxxxx> wrote:
> > I just added that onliner, it gives a nice symmetry to the CF card
> > IRQ.
>
> It seems you forgot to add braces as they are now needed for if .. else:
>
> + d = gpiod_get(NULL, "smc_irq", GPIOD_IN);
> + if (IS_ERR(d))
> + pr_err("Unable to get SMC IRQ GPIO descriptor\n");
> + else
> + irq_set_irq_type(gpiod_to_irq(d), IRQ_TYPE_EDGE_RISING);
> + osk5912_smc91x_resources[1] = DEFINE_RES_IRQ(gpiod_to_irq(d));
> +
Ooops fixed it.
> > > But I'm not sure why this is now needed?
> >
> > Me neither. I hope some people will test the other boards as well,
> > or I will fix them as they report breakage, as is custom.
>
> I will try to test all the OMAP1 boards.
Thanks!
I actually have the nokia 770. I will see if I can figure out how to hack
it.
Yours,
Linus Walleij
