Re: [PATCH v3] ARM/mfd/gpio: Fixup TPS65010 regression on OMAP1 OSK1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 15, 2023 at 11:02 PM Aaro Koskinen <aaro.koskinen@xxxxxx> wrote:

> There is still a problem that smc_irq is not working. It seems when I
> tested the previous version, I only quickly checked that the eth0 again
> probes and the link comes up, without testing any actual traffic - sorry.
>
> It seems the irq is stuck hi:
>
> gpiochip1: GPIOs 208-223, parent: platform/omap_gpio.1, gpio-0-15:
>  gpio-208 (                    |smc_irq             ) in  hi IRQ
>
> To fix it I had to add:
>
>         irq_set_irq_type(gpiod_to_irq(d), IRQ_TYPE_EDGE_RISING);

I just added that onliner, it gives a nice symmetry to the CF card
IRQ.

> But I'm not sure why this is now needed?

Me neither. I hope some people will test the other boards as well,
or I will fix them as they report breakage, as is custom.

Yours,
Linus Walleij




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux