Hi, On Thu, Apr 27, 2023 at 09:09:18AM +0200, Linus Walleij wrote: > On Thu, Apr 27, 2023 at 12:02 AM Aaro Koskinen <aaro.koskinen@xxxxxx> wrote: > > > > Fixes: 7b61212f2a07 ("gpiolib: Get rid of ARCH_NR_GPIOS") > > > > Fixes should be 92bf78b33b0b ("gpio: omap: use dynamic allocation > > of base"). > > OK I fix Fixes. > > > Thanks, the patch almost works - I can now boot all the way to rootfs > > (USB disk), and also ethernet works. > > That's actually surprisingly good results... Then we can certainly > fix this up and get it working. > > > However CF is not working: > > > > [ 0.276947] (NULL device *): requested GPIO 0 (62) is out of range [0..15] for chip gpio-0-15 > > [ 0.277130] Unable to get CF IRQ GPIO descriptor > > Ooops no surprise there. Which gpiochips do you have on OMAP1? > Just a simple cat /sys/kernel/debug/gpio should give the answer. Got it working with: - GPIO_LOOKUP(OMAP_GPIO_LABEL, 62, "cf_irq", + GPIO_LOOKUP("gpio-48-63", 14, "cf_irq", (BTW, I think these tables are more readable with just string literals instead of OMAP_GPIO_LABEL...) Here's full lists from OSK, 770, SX1 and Palm TE with v6.2: OSK: gpiochip1: GPIOs 0-15, parent: platform/omap_gpio.1, gpio-0-15: gpio-0 ( |smc_irq ) in lo IRQ gpio-9 ( |OHCI overcurrent ) in hi gpiochip2: GPIOs 16-31, parent: platform/omap_gpio.2, gpio-16-31: gpio-18 ( |UART wake ) in lo IRQ gpiochip3: GPIOs 32-47, parent: platform/omap_gpio.3, gpio-32-47: gpio-37 ( |UART wake ) in lo IRQ gpiochip4: GPIOs 48-63, parent: platform/omap_gpio.4, gpio-48-63: gpio-49 ( |UART wake ) in lo IRQ gpio-62 ( |cf_irq ) in hi IRQ gpiochip0: GPIOs 192-207, parent: platform/omap_gpio.0, mpuio: gpio-193 ( |tps65010 ) in hi IRQ gpiochip5: GPIOs 208-214, parent: i2c/i2c-tps65010, tps65010, can sleep: gpio-208 ( |OHCI power ) out lo gpio-210 ( |smc_reset ) out lo gpio-211 ( |dsp_power ) out hi 770: gpiochip1: GPIOs 0-15, parent: platform/omap_gpio.1, gpio-0-15: gpio-15 ( |ads7846_pendown ) in hi IRQ gpiochip2: GPIOs 16-31, parent: platform/omap_gpio.2, gpio-16-31: gpio-18 ( |UART wake ) in lo IRQ gpio-23 ( |MMC cover ) in lo gpiochip3: GPIOs 32-47, parent: platform/omap_gpio.3, gpio-32-47: gpio-37 ( |UART wake ) in lo IRQ gpio-40 ( |Tahvo IRQ ) in lo IRQ gpio-41 ( |MMC power ) out hi gpiochip4: GPIOs 48-63, parent: platform/omap_gpio.4, gpio-48-63: gpio-49 ( |UART wake ) in hi IRQ gpio-62 ( |Retu IRQ ) in lo IRQ gpiochip0: GPIOs 192-207, parent: platform/omap_gpio.0, mpuio: gpio-201 ( |CBUS clk ) out lo gpio-202 ( |CBUS dat ) out lo gpio-203 ( |CBUS sel ) out hi SX1: gpiochip1: GPIOs 0-15, parent: platform/omap_gpio.1, gpio-0-15: gpio-1 ( |A_IRDA_OFF ) out lo gpio-11 ( |A_SWITCH ) out lo gpio-15 ( |A_USB_ON ) out lo gpiochip0: GPIOs 192-207, parent: platform/omap_gpio.0, mpuio: Palm TE: gpiochip1: GPIOs 0-15, parent: platform/omap_gpio.1, gpio-0-15: gpio-1 ( |USB/DC-IN ) in lo gpio-6 ( |TSC2102 PINTDAV ) in hi gpiochip0: GPIOs 192-207, parent: platform/omap_gpio.0, mpuio: A.