Hi Köry, I love your patch! Perhaps something to improve: [auto build test WARNING on v6.2] [also build test WARNING on next-20230303] [cannot apply to net/master net-next/master horms-ipvs/master linus/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230304-004527 patch link: https://lore.kernel.org/r/20230303164248.499286-4-kory.maincent%40bootlin.com patch subject: [PATCH v2 3/4] net: Let the active time stamping layer be selectable. config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230304/202303040219.nmNWbGrY-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/00a0656f9b222cfeb7c1253a4a2771b1f63b5c9b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230304-004527 git checkout 00a0656f9b222cfeb7c1253a4a2771b1f63b5c9b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/core/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303040219.nmNWbGrY-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): net/core/net-sysfs.c: In function 'available_timestamping_providers_show': net/core/net-sysfs.c:627:35: warning: variable 'ops' set but not used [-Wunused-but-set-variable] 627 | const struct ethtool_ops *ops; | ^~~ net/core/net-sysfs.c: In function 'current_timestamping_provider_show': >> net/core/net-sysfs.c:659:28: warning: variable 'phydev' set but not used [-Wunused-but-set-variable] 659 | struct phy_device *phydev; | ^~~~~~ net/core/net-sysfs.c:657:35: warning: variable 'ops' set but not used [-Wunused-but-set-variable] 657 | const struct ethtool_ops *ops; | ^~~ vim +/phydev +659 net/core/net-sysfs.c 90d54e1c6ed12a Richard Cochran 2023-03-03 652 90d54e1c6ed12a Richard Cochran 2023-03-03 653 static ssize_t current_timestamping_provider_show(struct device *dev, 90d54e1c6ed12a Richard Cochran 2023-03-03 654 struct device_attribute *attr, 90d54e1c6ed12a Richard Cochran 2023-03-03 655 char *buf) 90d54e1c6ed12a Richard Cochran 2023-03-03 656 { 90d54e1c6ed12a Richard Cochran 2023-03-03 657 const struct ethtool_ops *ops; 90d54e1c6ed12a Richard Cochran 2023-03-03 658 struct net_device *netdev; 90d54e1c6ed12a Richard Cochran 2023-03-03 @659 struct phy_device *phydev; 90d54e1c6ed12a Richard Cochran 2023-03-03 660 int ret; 90d54e1c6ed12a Richard Cochran 2023-03-03 661 90d54e1c6ed12a Richard Cochran 2023-03-03 662 netdev = to_net_dev(dev); 90d54e1c6ed12a Richard Cochran 2023-03-03 663 phydev = netdev->phydev; 90d54e1c6ed12a Richard Cochran 2023-03-03 664 ops = netdev->ethtool_ops; 90d54e1c6ed12a Richard Cochran 2023-03-03 665 90d54e1c6ed12a Richard Cochran 2023-03-03 666 if (!rtnl_trylock()) 90d54e1c6ed12a Richard Cochran 2023-03-03 667 return restart_syscall(); 90d54e1c6ed12a Richard Cochran 2023-03-03 668 00a0656f9b222c Richard Cochran 2023-03-03 669 switch (netdev->selected_timestamping_layer) { 00a0656f9b222c Richard Cochran 2023-03-03 670 case MAC_TIMESTAMPING: 90d54e1c6ed12a Richard Cochran 2023-03-03 671 ret = sprintf(buf, "%s\n", "mac"); 00a0656f9b222c Richard Cochran 2023-03-03 672 break; 00a0656f9b222c Richard Cochran 2023-03-03 673 case PHY_TIMESTAMPING: 00a0656f9b222c Richard Cochran 2023-03-03 674 ret = sprintf(buf, "%s\n", "phy"); 00a0656f9b222c Richard Cochran 2023-03-03 675 break; 90d54e1c6ed12a Richard Cochran 2023-03-03 676 } 90d54e1c6ed12a Richard Cochran 2023-03-03 677 90d54e1c6ed12a Richard Cochran 2023-03-03 678 rtnl_unlock(); 90d54e1c6ed12a Richard Cochran 2023-03-03 679 90d54e1c6ed12a Richard Cochran 2023-03-03 680 return ret; 90d54e1c6ed12a Richard Cochran 2023-03-03 681 } 00a0656f9b222c Richard Cochran 2023-03-03 682 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
